Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Grab bag of fixes #239

Merged
merged 8 commits into from
Jan 6, 2015
Merged

Grab bag of fixes #239

merged 8 commits into from
Jan 6, 2015

Commits on Jan 6, 2015

  1. cmd/rlpdump: remove stray return

    @fjl
    fjl committed Jan 6, 2015
    Configuration menu
    Copy the full SHA
    fde0ddb View commit details
    Browse the repository at this point in the history

  2. cmd/evm: add dummy implementation for GetHash 

    Fixes the build. AFAIK evm does not bother keeping a chain and
cannot provide a real implementation.
    @fjl
    fjl committed Jan 6, 2015
    Configuration menu
    Copy the full SHA
    be97785 View commit details
    Browse the repository at this point in the history

  3. cmd/peerserver: fix for new client identity type

    @fjl
    fjl committed Jan 6, 2015
    Configuration menu
    Copy the full SHA
    545e146 View commit details
    Browse the repository at this point in the history

  4. cmd/peerserver: use NoDial, don't use seed peers

    @fjl
    fjl committed Jan 6, 2015
    Configuration menu
    Copy the full SHA
    4c8c115 View commit details
    Browse the repository at this point in the history

  5. cmd/peerserver: add some command line switches

    @fjl
    fjl committed Jan 6, 2015
    Configuration menu
    Copy the full SHA
    36e1e5f View commit details
    Browse the repository at this point in the history

  6. eth, p2p: remove EncodeMsg from p2p.MsgWriter 

    ...and make it a top-level function instead.

The original idea behind having EncodeMsg in the interface was that
implementations might be able to encode RLP data to their underlying
writer directly instead of buffering the encoded data. The encoder
will buffer anyway, so that doesn't matter anymore.

Given the recent problems with EncodeMsg (copy-pasted implementation
bug) I'd rather implement once, correctly.
    @fjl
    fjl committed Jan 6, 2015
    Configuration menu
    Copy the full SHA
    eb0e7b1 View commit details
    Browse the repository at this point in the history

  7. p2p: move peerList back into baseProtocol 

    It had been moved to Peer, probably for debugging.
    @fjl
    fjl committed Jan 6, 2015
    Configuration menu
    Copy the full SHA
    b0ff946 View commit details
    Browse the repository at this point in the history

  8. p2p: improve test for peers message 

    The test now checks that the number of of addresses is correct
and terminates cleanly.
    @fjl
    fjl committed Jan 6, 2015
    Configuration menu
    Copy the full SHA
    3caa4ad View commit details
    Browse the repository at this point in the history