Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

eth/tracers: clean-up tracer collection #24320

Merged
merged 2 commits into from
Feb 1, 2022
Merged

eth/tracers: clean-up tracer collection #24320

merged 2 commits into from
Feb 1, 2022

Conversation

s1na
Copy link
Contributor

@s1na s1na commented Jan 31, 2022

Includes a few changes:

  • Make native prestate tracer the default and rename the JS one to prestateTracerLegacy
  • Make native noop tracer the default and rename the JS one to noopTracerLegacy
  • Drop the scope-based JS call tracer. Now we only have the native scope-based call tracer and the step-based JS legacy call tracer

holiman
holiman approved these changes Feb 1, 2022
View reviewed changes
Copy link
Contributor

@holiman holiman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@holiman holiman added this to the 1.10.16 milestone Feb 1, 2022
@holiman holiman merged commit c5436c8 into ethereum:master Feb 1, 2022
sidhujag pushed a commit to syscoin/go-ethereum that referenced this pull request Feb 1, 2022
@s1na
eth/tracers: clean-up tracer collection (ethereum#24320)
b9c8e56 
* eth/tracers: clean-up tracer collection

* Rm test for dropped tracer
JacekGlen pushed a commit to JacekGlen/go-ethereum that referenced this pull request May 26, 2022
@s1na @JacekGlen
eth/tracers: clean-up tracer collection (ethereum#24320)
ee3de85 
* eth/tracers: clean-up tracer collection

* Rm test for dropped tracer
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@holiman holiman holiman approved these changes

@karalabe karalabe Awaiting requested review from karalabe

@rjl493456442 rjl493456442 Awaiting requested review from rjl493456442

Assignees
No one assigned
Labels
status:triage
Projects
None yet
Milestone
1.10.16
Development

Successfully merging this pull request may close these issues.
3 participants
@s1na @holiman @ligi