accounts/url: add test logic what check null string to parseURL()

[dbadoy]

accounts/url: add test logic what check null string to parseURL() #25011

[holiman]

An alternative way to do this which is a bit more easily extendable would be this:

	for _, u := range []string{"ethereum.org", ""}{
		if _, err = parseURL(u); err == nil {
			t.Errorf("input %v, expected err, got: nil", u)
		}
	}

As it's a kind of small test though, I don't have a problem with the way you've done it

[dbadoy]

appreciate it.
It's applied.

[dbadoy]

if len(parts) != 2 || parts[0] == ""

// parts[0] == "" is this necessary?

parts := strings.split(url, "://")
// "ethereum.org"
// ""
// length: 1

[tbcd]

That's because parseURL("") does not test anything more than parseURL("ethereum.org") already tested.

It does not test the || parts[0] == "" branch that you intended. It would need to be something like parseURL("://ethereum.org").

Edit: Re-reading the issue title and PR title, it seems like you misunderstood the purpose of the branch in the first place. It was to test for an empty scheme string result, not an empty URL string being passed into the function.

[cesarvspr]

File is not `goimports`-ed

This error is being raised, any idea why? @dbadoy

[dbadoy]

Sorry. close this PR because there was a mistake in the merge.