accounts/abi/bind, eth: rely on getCode for sanity checks, not estimate and call #2589
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated: Fri May 20 13:13:34 UTC 2016 |
|
Have not tried it but code looks 👍 |
|
👍 |
maoueh
pushed a commit
to streamingfast/go-ethereum
that referenced
this pull request
Aug 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A while ago we've added a semantic modification to
estimateGasto return an error message if no contract was available to call. Turned out that people were using estimate gas for plain transfers too, which broke. Given that estimate gas should just plain estimate whatever it's given, this PR reverts that change, and instead moves contract code checking into the native dapp backends.Fixes #2577