Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

miner: compute tx fees for blocks #25998

Closed
wants to merge 23 commits into from
Closed

miner: compute tx fees for blocks #25998

wants to merge 23 commits into from

Conversation

MariusVanDerWijden
Copy link
Member

@MariusVanDerWijden MariusVanDerWijden commented Oct 16, 2022 •
edited
Loading

computes and returns the payload fees for a block.
Spec for it is here: ethereum/execution-apis#314

@MariusVanDerWijden MariusVanDerWijden changed the title Payload fees miner: compute tx fees for blocks Oct 16, 2022
@allboxes allboxes mentioned this pull request Oct 16, 2022
Closed
lightclient
lightclient reviewed Oct 16, 2022
View reviewed changes
core/beacon/types.go Outdated Show resolved Hide resolved
@metachris
Copy link

metachris commented Oct 17, 2022 •
edited
Loading

semi-related / for reference: the mev-boost block scoring discussion

dcposch
dcposch reviewed Oct 18, 2022
View reviewed changes
core/beacon/types.go Outdated Show resolved Hide resolved
@terencechain terencechain mentioned this pull request Oct 24, 2022
Closed
@MarekM25 MarekM25 mentioned this pull request Oct 25, 2022
Closed
@MariusVanDerWijden MariusVanDerWijden mentioned this pull request Oct 27, 2022
Merged
@holiman
Copy link
Contributor

holiman commented Nov 4, 2022

@MariusVanDerWijden is this still needed? If so, please rebase and un-draft, otherwise close

@MariusVanDerWijden
Copy link
Member Author

Yes it is needed, the spec is not final so I am not going to un-draft it. But I'm rebasing it rn

lightclient and others added 19 commits November 29, 2022 18:21
@lightclient
core/types: add withdrawal type
774be0e
@lightclient
core/beacon: add withdrawals and make types version agnostic
c27745f
@lightclient
eth/catalyst,les/catalyst: add withdrawals and make types version agn…
994b761 
…ostic
@lightclient
miner: add withdrawals and update catalyst types
a512496
@lightclient
consensus: process withdrawals
7d7fb2f
@lightclient
core/state_processor: finalize with withdrawals
58218c9
@lightclient
core/chain_makers: add withdrawal support
72ec036
@lightclient
core/block_validator: verify withdrawals root
2ebb038
@lightclient
core/rawdb: update block readers with new block format
a6e56c5
@lightclient
eth: add p2p support for withdrawals
a5853bb
@lightclient
cmd/evm: support withdrawals in t8n and b11r
9ad8070
@lightclient @marioevz
eth/downloader: always use WithBody2 when constructing blocks
97c2474 
Co-authored-by: lightclient <[email protected]>
Co-authored-by: marioevz <[email protected]>
@lightclient
eth/fetcher: always use WithBody2 when constructing blocks
256e54c
@MariusVanDerWijden @lightclient
params: core: enable shanghai based on timestamps
7a817ba
@MariusVanDerWijden @lightclient
params: nitpicks
858ac2f
@lightclient
core,consensus: use timestamp based is shanghai check
798a3e4
@lightclient
consensus: fail if running shanghai on clique or ethash
0f30e74
@MariusVanDerWijden @lightclient
core: set withdrawals hash in genesis, fix tests, add withdrawalRoot
e8c8df4
@MariusVanDerWijden
all: implement forkid changes for shanghai
19b4bc8
@MariusVanDerWijden
Copy link
Member Author

closing and reopening against lightclients withdrawal-timestamp branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lightclient lightclient lightclient left review comments

@dcposch dcposch dcposch left review comments

@fjl fjl Awaiting requested review from fjl fjl will be requested when the pull request is marked ready for review fjl is a code owner

@holiman holiman Awaiting requested review from holiman holiman will be requested when the pull request is marked ready for review holiman is a code owner

@karalabe karalabe Awaiting requested review from karalabe karalabe will be requested when the pull request is marked ready for review karalabe is a code owner

@gballet gballet Awaiting requested review from gballet gballet will be requested when the pull request is marked ready for review gballet is a code owner

@rjl493456442 rjl493456442 Awaiting requested review from rjl493456442 rjl493456442 will be requested when the pull request is marked ready for review rjl493456442 is a code owner

@zsfelfoldi zsfelfoldi Awaiting requested review from zsfelfoldi zsfelfoldi will be requested when the pull request is marked ready for review zsfelfoldi is a code owner

@s1na s1na Awaiting requested review from s1na s1na will be requested when the pull request is marked ready for review s1na is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@MariusVanDerWijden @metachris @holiman @dcposch @lightclient