Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

all: use atomic type added in go1.19 #26820

Closed
wants to merge 1 commit into from
Closed

all: use atomic type added in go1.19 #26820

wants to merge 1 commit into from

Conversation

s7v7nislands
Copy link
Contributor

No description provided.

@holiman
Copy link
Contributor

holiman commented Mar 7, 2023

This is becoming gigantic, and I'n not 100% sure that each and every change is trivial (?). Might it be better to do a few packages at a time maybe?

@karalabe
Copy link
Member

karalabe commented Mar 7, 2023

Myeah, this is definitely not gonna fly like this. Please open multiple PRs with more constrained changes. Not necessarily saying one PR per package, but something more meaningfully scoped and reviewable.

@karalabe karalabe closed this Mar 7, 2023
@s7v7nislands
Copy link
Contributor Author

Ok, I will do that!

This was referenced Mar 17, 2023
Merged
Merged
Merged
@s7v7nislands s7v7nislands deleted the update_atomic branch March 22, 2023 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@holiman holiman Awaiting requested review from holiman holiman will be requested when the pull request is marked ready for review holiman is a code owner

@fjl fjl Awaiting requested review from fjl fjl will be requested when the pull request is marked ready for review fjl is a code owner

@zsfelfoldi zsfelfoldi Awaiting requested review from zsfelfoldi zsfelfoldi will be requested when the pull request is marked ready for review zsfelfoldi is a code owner

@rjl493456442 rjl493456442 Awaiting requested review from rjl493456442 rjl493456442 will be requested when the pull request is marked ready for review rjl493456442 is a code owner

@s1na s1na Awaiting requested review from s1na s1na will be requested when the pull request is marked ready for review s1na is a code owner

@karalabe karalabe Awaiting requested review from karalabe karalabe will be requested when the pull request is marked ready for review karalabe is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@s7v7nislands @holiman @karalabe