Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eth: ignore genesis block on importChain #27956

Merged
merged 1 commit into from
Aug 21, 2023

Conversation

MariusVanDerWijden
Copy link
Member

@MariusVanDerWijden MariusVanDerWijden commented Aug 21, 2023

This PR ignores the genesis block when importing a previously exported chain.
The genesis block can not be imported anyway which will lead to bad blocks due to unknown ancestor.

Copy link
Contributor

@holiman holiman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with the change (but I'm a bit confounded as to why this change is needed not and wasn't done five years ago)

@holiman holiman added this to the 1.13.0 milestone Aug 21, 2023
@holiman holiman merged commit b3024e8 into ethereum:master Aug 21, 2023
1 check passed
devopsbo3 pushed a commit to HorizenOfficial/go-ethereum that referenced this pull request Nov 10, 2023
devopsbo3 added a commit to HorizenOfficial/go-ethereum that referenced this pull request Nov 10, 2023
devopsbo3 added a commit to HorizenOfficial/go-ethereum that referenced this pull request Nov 10, 2023
sduchesneau pushed a commit to streamingfast/go-ethereum that referenced this pull request Feb 26, 2024
upstream PR ethereum#27956 ignores the-0 block when importing.
Also ignore pre-arbitrum-genesis blocks.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants