-
Notifications
You must be signed in to change notification settings - Fork 20.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ethdb/pebble: upgrade pebble #28070
ethdb/pebble: upgrade pebble #28070
Conversation
Start another round of benchmark, run full sync on bench05/06, 05 is PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Switch to full sync for a few days, dump some metrics here Overall system metricsNot too much difference DatabaseThis pull request has ~10% disk read, otherwise pretty much same(bench05 is 4 hours ahead) Sync performanceThis pull request is ~3hours a head after running 3 or 4 days. A little faster, but not too much The conclusion is, with the change of cockroachdb/pebble#2846, a few unnecessary disk reads are avoid. |
741779a
to
3984a5b
Compare
3984a5b
to
9ad7faf
Compare
Given the strange IO issues on Pebble 23.1, this branch got a priority merge 🙃 |
* ethdb/pebble: upgrade pebble * ethdb/pebble, go.mod: update pebble to master (aa077af62593) --------- Co-authored-by: Péter Szilágyi <[email protected]>
* ethdb/pebble: upgrade pebble * ethdb/pebble, go.mod: update pebble to master (aa077af62593) --------- Co-authored-by: Péter Szilágyi <[email protected]>
* ethdb/pebble: upgrade pebble * ethdb/pebble, go.mod: update pebble to master (aa077af62593) --------- Co-authored-by: Péter Szilágyi <[email protected]>
* ethdb/pebble: upgrade pebble * ethdb/pebble, go.mod: update pebble to master (aa077af62593) --------- Co-authored-by: Péter Szilágyi <[email protected]>
* ethdb/pebble: upgrade pebble * ethdb/pebble, go.mod: update pebble to master (aa077af62593) --------- Co-authored-by: Péter Szilágyi <[email protected]>
This PR upgrades the pebble dependencies with two features merged:
The intention is not to merge this pull request immediately, but wait a bit more for a stable release from pebble.