ethclient: use 'input', not 'data' as field for transaction input

[holiman]

Closes #28077

This makes ethclient / gethclient use input instead of data for passing input with a transaction. input is the preferred way.

See #15628, and https://github.com/ethereum/go-ethereum/blob/master/signer/core/apitypes/types.go#L93

[s1na]

LGTM

[smartprogrammer93]

Just a heads up, guys. This will break with the current implementation of prysm since they use eth_call with the data field currently.

[peterbitfly]

FYI, this breaks calling contracts with ethclient against an erigon node, as erigon still expects the data to be passed in the data field.

[holiman]

as erigon still expects the data to be passed in the data field.

That is very odd, https://github.com/ledgerwatch/erigon/blob/devel/core/types/transaction_marshalling.go#L29

	Data     *hexutility.Bytes  `json:"input"`

Are you quite certain?

[peterbitfly]

Not sure if their RPC implementation uses a different decoding routine. But our tests against a node show that behavior: erigontech/erigon#8437

Edit: I believe erigon uses the following definition in this case https://github.com/ledgerwatch/erigon/blob/fe263ae02e08df8119cae7eaa54e49e75141762b/interfaces.go#L118

[holiman]

That strange too, because we have the same struct: https://github.com/ethereum/go-ethereum/blob/master/interfaces.go#L142

[holiman]

Hm, looking closer, this PR description talks about "transaction input", but in fact it addresses a parameter used in eth_call, not (directly) related to the transaction type. So maybe the spec (https://github.com/ethereum/execution-apis/blob/main/src/schemas/transaction.yaml#L25) posted in #28077 does not concern eth_call at all.

?

[fjl]

The spec object is for both. I think what happened in erigon might be, they used CallMsg instead of our TransactionArgs to represent the input. The ethereum.CallArgs type does not have an UnmarshalJSON method, it's just a Go struct containing the call parameters. We have custom serialization code for it in ethclient.

[holiman]

https://hivetests2.ethdevops.io/suite.html?suiteid=1697083845-025eee594dcbf6ac1c1aea97aa153fe3.json&suitename=rpc#test-2

>>  {"jsonrpc":"2.0","id":1,"method":"eth_call","params":[{"from":"0x0000000000000000000000000000000000000000","input":"0xa223e05d","to":"0x0000000000000000000000000000000000000314"},"pending"]}
<<  {"jsonrpc":"2.0","id":1,"result":"0x0000000000000000000000000000000000000000000000000000000000001234"}
>>  {"jsonrpc":"2.0","id":2,"method":"eth_call","params":[{"from":"0x0000000000000000000000000000000000000000","input":"0xabd1a0cf000000000000000000000000391694e7e0b0cce554cb130d723a9d27458f9298","to":"0x0000000000000000000000000000000000000314"},"pending"]}
<<  {"jsonrpc":"2.0","id":2,"result":"0x0000000000000000000000000000000000000000000000000000000000000001"}
>>  {"jsonrpc":"2.0","id":3,"method":"eth_call","params":[{"from":"0x0000000000000000000000000000000000000000","input":"0xe6768b45000000000000000000000000000000000000000000000000000000000000045700000000000000000000000000000000000000000000000000000000000008ae0000000000000000000000000000000000000000000000000000000000000d05","to":"0x0000000000000000000000000000000000000314"},"pending"]}
<<  {"jsonrpc":"2.0","id":3,"result":"0x000000000000000000000000000000000000000000000000000000000000045700000000000000000000000000000000000000000000000000000000000008ae0000000000000000000000000000000000000000000000000000000000000d05"}

The hive-tests indicate that erigon does support input. cc @AskAlexSharov any thoughts?

[fengzie]

It caused me more than a half day for troubleshooting a chain about "execution reverted" issue. The go-ethereum v1.13.8 uses "input" in eth_call instead of "data".