core/state: small trie prefetcher nits #28183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaronbuchwald
requested review from
karalabe,
holiman and
rjl493456442
as code owners
|
Master: |
fjl
changed the title
Nice, next time I get the chance will try to look for benchmarks to run and include in the PR description. |
rjl493456442
approved these changes
Sep 27, 2023
hyunchel
pushed a commit
to hyunchel/go-ethereum
that referenced
this pull request
Oct 6, 2023
Small trie prefetcher nits
tyler-smith
pushed a commit
to blocknative/go-ethereum
that referenced
this pull request
Oct 12, 2023
Small trie prefetcher nits
tyler-smith
pushed a commit
to blocknative/go-ethereum
that referenced
this pull request
Oct 16, 2023
Small trie prefetcher nits
devopsbo3
pushed a commit
to HorizenOfficial/go-ethereum
that referenced
this pull request
Nov 10, 2023
Small trie prefetcher nits
devopsbo3
added a commit
to HorizenOfficial/go-ethereum
that referenced
this pull request
Nov 10, 2023
This reverts commit ab25e35.
devopsbo3
added a commit
to HorizenOfficial/go-ethereum
that referenced
this pull request
Nov 10, 2023
This reverts commit ab25e35.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a comment to the trie prefetcher
fetchesfield to make it clear when it will be populated (I found this non-obvious when reading through the code) and updatestrieIDto allocate a slice up front and copy in rather than usingappend.Just small nits I found while reviewing the code, hope it's helpful 🫡