Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: upgrade to golang 1.21.2 #28268

Closed
wants to merge 2 commits into from
Closed

Conversation

holiman
Copy link
Contributor

@holiman holiman commented Oct 6, 2023

Upgrades to 1.21.2.

This PR also includes a tool to sanity-check the checksums in our checksum list. I expanded the semantics of the checksum txt file, so that a line starting with # https sets a new base-url, and we can download and verify each hash/file combo under the given base url.

Execute with go run ./build/ci.go sanitycheck.

Also, if we decide this is a nice idea, then we can make the fixtures-download use this scheme, and we don't have to have a fixtures-version in the main ci.go -- this part:

func downloadSpecTestFixtures(csdb *build.ChecksumDB, cachedir string) string {
	ext := ".tar.gz"
	base := "fixtures" // TODO(MariusVanDerWijden) rename once the version becomes part of the filename
	url := fmt.Sprintf("https://github.com/ethereum/execution-spec-tests/releases/download/v%s/%s%s", executionSpecTestsVersion, base, ext)

We could instead just infer it from the checksumdb.

@holiman holiman marked this pull request as ready for review October 6, 2023 07:38
@holiman holiman closed this Oct 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant