cmd/devp2p/internal/ethtest: skip large tx test on github build

[s1na]

This test was failling consistently on the github 32-bit build probably due to slow IO. Skipping it for that green check.

[fjl]

I would prefer if we skip the test in the actual Go unit test that runs this instead of excluding it from the list here. The tests are executed here:

go-ethereum/cmd/devp2p/internal/ethtest/suite_test.go

Line 66 in 2e8b118

result := utesting.RunTests([]utesting.Test{{Name: test.Name, Fn: test.Fn}}, os.Stdout)

So please add a condition there, like

if bits.UintSize == 32 && test.Name == "TestLargeTxRequest" {
    t.Skip()
}

[holiman]

I would prefer to use different semantics. Instead of
"Are we running on 32-bit? If so, skip", the logic should be
"Are we running with the tag short? If so, skip".

[holiman]

I.e

	if testing.Short() && test.Name == "TestLargeTxRequest"{
		t.Skip("skipped in short-mode")
	}

[s1na]

Please take another look. I refactored so skipping is based both on short tag or 386 arch. This is similar to how we decide on skipping the state tests:

go-ethereum/tests/init_test.go

Lines 144 to 149 in ae4ea04

	if testing.Short() {
	return "skipped in -short mode", false
	}
	if isWin32 {
	return "skipped on 32bit windows", false
	}

[holiman]

Imo use only short. Everything else is wrong :)

[s1na]

Imo use only short. Everything else is wrong :)

Done

[fjl]

Waiting for builds

[holiman]

LGTM