Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eth/catalyst,beacon/engine: implement GetClientVersionV1 #28915

Merged
merged 3 commits into from
Feb 15, 2024

Conversation

lightclient
Copy link
Member

This implements the new method engine_getClientVersionV1. Still waiting it to be merged here: ethereum/execution-apis#517

beacon/engine/types.go Outdated Show resolved Hide resolved
@fjl
Copy link
Contributor

fjl commented Feb 12, 2024

Spec has been changed to return an array of versions.

@lightclient lightclient marked this pull request as ready for review February 13, 2024 13:11
@lightclient
Copy link
Member Author

Okay the PR was merged ethereum/execution-apis#517, this should be good to go!

Code: engine.ClientCode,
Name: engine.ClientName,
Version: params.VersionWithMeta,
Commit: hexutil.Encode(commit),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will add 0x in the commit. Is this seriously what they decided on within the spec?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fjl fjl merged commit 9e3e466 into ethereum:master Feb 15, 2024
2 of 3 checks passed
@fjl fjl added this to the 1.13.13 milestone Feb 15, 2024
@MariusVanDerWijden
Copy link
Member

Looks like you forgot to add it into the list of capabilites

jorgemmsilva pushed a commit to iotaledger/go-ethereum that referenced this pull request Jun 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants