eth: return timestamp for getLogs rpc #29914
Closed
+71
−53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
June 3, 2024 08:19
Signed-off-by: tmelhao <[email protected]>
Signed-off-by: tmelhao <[email protected]>
Signed-off-by: tmelhao <[email protected]>
Signed-off-by: tmelhao <[email protected]>
Signed-off-by: tmelhao <[email protected]>
Signed-off-by: tmelhao <[email protected]>
Signed-off-by: tmelhao <[email protected]>
|
Hi @tmelhao! Thanks for this implementation. Because this is still blocked on updating the api spec in the first place, I'm going to close this for now. If you're interested in helping move that spec change forward, I think it would be useful for you to champion it on ACD. Here is a document which describes the process for changing the eth api: https://github.com/ethereum/execution-apis/blob/main/docs/making-changes.md Please reopen as soon as the spec has been updated. Thanks! |
|
@lightclient thanks for the information, I'll take a look at the api spec, and let's reopen this PR after the api spec updated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
implement ethereum/execution-apis#295