go.mod: remove github.com/julienschmidt/httprouter
#30290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
islishude
changed the title
github.com/julienschmidt/httproutergithub.com/julienschmidt/httprouter and add ci step to check if go mod is tidy
|
Can you remove the CI step for now? We will debate if it should be added. |
islishude
changed the title
github.com/julienschmidt/httprouter and add ci step to check if go mod is tidygithub.com/julienschmidt/httprouter
Updated |
|
I recalled I commented the same issue before geth should add the ci step to avoid it again |
lightclient
approved these changes
Aug 12, 2024
rjl493456442
pushed a commit
to rjl493456442/go-ethereum
that referenced
this pull request
Aug 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
missing
go mod tidyin #30250