cmd,eth: register live tracer RPCs #30308
Open
+59
−43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsvisa
requested review from
s1na,
karalabe,
holiman and
rjl493456442
as code owners
s1na
reviewed
Aug 21, 2024
s1na
reviewed
Aug 21, 2024
jsvisa
force-pushed
the
lazy-init-tracer
branch
from
c378326
to
0625e8b
Compare
jsvisa
changed the title
…stead Signed-off-by: jsvisa <[email protected]>
Signed-off-by: jsvisa <[email protected]>
Signed-off-by: jsvisa <[email protected]>
Signed-off-by: jsvisa <[email protected]>
Signed-off-by: jsvisa <[email protected]>
jsvisa
force-pushed
the
lazy-init-tracer
branch
from
0625e8b
to
6a242ba
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @s1na, could you please review this pre-PR for the live trace_xxx RPC? Below are the main points covered in this PR:
tracing.Backendinterface, which will be utilized internally.[]rpc.API, so we can usestack.RegisterAPIsto register the JSON-RPC interfaces.BlockChain.SetLogger, has been added to enable setting the live tracer once it is fully initialized.