accounts/abi: handle ABIs with contract type parameter

[chen4903]

A PR to fix: #30266
The ABI pulled from Etherscan sometimes does not conform to the specifications, so before formally processing the ABI, we validate whether the input ABI meets the standards.

[MariusVanDerWijden]

What do you think about this:

diff --git a/accounts/abi/type.go b/accounts/abi/type.go
index d57fa3d4e6..1f0119e36c 100644
--- a/accounts/abi/type.go
+++ b/accounts/abi/type.go
@@ -219,7 +219,15 @@ func NewType(t string, internalType string, components []ArgumentMarshaling) (ty
                typ.T = FunctionTy
                typ.Size = 24
        default:
-               return Type{}, fmt.Errorf("unsupported arg type: %s", t)
+               // Filter out these edgecases
+               // {"internalType":"contract INameService","name":"nameService","type":"INameService"},
+               // where solidity replaces an address type with its (undefined) name.
+               if strings.Contains(internalType, "contract") {
+                       typ.Size = 20
+                       typ.T = AddressTy
+               } else {
+                       return Type{}, fmt.Errorf("unsupported arg type: %s", t)
+               }

[chen4903]

What do you think about this:

diff --git a/accounts/abi/type.go b/accounts/abi/type.go
index d57fa3d4e6..1f0119e36c 100644
--- a/accounts/abi/type.go
+++ b/accounts/abi/type.go
@@ -219,7 +219,15 @@ func NewType(t string, internalType string, components []ArgumentMarshaling) (ty
                typ.T = FunctionTy
                typ.Size = 24
        default:
-               return Type{}, fmt.Errorf("unsupported arg type: %s", t)
+               // Filter out these edgecases
+               // {"internalType":"contract INameService","name":"nameService","type":"INameService"},
+               // where solidity replaces an address type with its (undefined) name.
+               if strings.Contains(internalType, "contract") {
+                       typ.Size = 20
+                       typ.T = AddressTy
+               } else {
+                       return Type{}, fmt.Errorf("unsupported arg type: %s", t)
+               }

Yeah, this way is more concise and efficient.

[holiman]

LGTM