Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core/rawdb: drop MigrateTable #30331

Merged
merged 1 commit into from
Aug 20, 2024
Merged

Conversation

s1na
Copy link
Contributor

@s1na s1na commented Aug 20, 2024

These are the leftovers from #24028.

@holiman
Copy link
Contributor

holiman commented Aug 20, 2024

Myeah, or rather leftovers that should have been removed in 10347c6#diff-b17377260117e22987b2b978a970b51a6a6bf8afbc6416242db9f55c589fa2daL198 .

Copy link
Contributor

@holiman holiman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@holiman holiman merged commit 3b48b16 into ethereum:master Aug 20, 2024
2 of 3 checks passed
@holiman holiman added this to the 1.14.9 milestone Aug 20, 2024
@s1na
Copy link
Contributor Author

s1na commented Aug 20, 2024

Myeah, or rather leftovers that should have been removed in

Yep definitely. I think at the time I was young and thinking MigrateTable is generic enough to be used for other purposes. But it is bitrotting and if we at anytime need it I can fetch it from the git history.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants