Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ethdb/pebble: handle error in pebble module #30367

Merged
merged 4 commits into from
Sep 19, 2024

Conversation

mask-pp
Copy link
Contributor

@mask-pp mask-pp commented Aug 28, 2024

  • Handle error in pebble module
  • Use common.CopyBytes

ethdb/pebble/pebble.go Outdated Show resolved Hide resolved
ethdb/pebble/pebble.go Outdated Show resolved Hide resolved
@mask-pp mask-pp requested a review from holiman August 29, 2024 08:16
Copy link
Member

@karalabe karalabe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM, can emrge after release

@karalabe karalabe added this to the 1.14.10 milestone Sep 17, 2024
Copy link
Contributor

@holiman holiman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but let's wait until after a release before merging it

@holiman holiman merged commit 7513966 into ethereum:master Sep 19, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants