core: reduce scope of effectiveTip related variables #30483
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhiqiangxu
requested review from
karalabe,
holiman and
rjl493456442
as code owners
zhiqiangxu
force-pushed
the
reduce_scope
branch
from
19a68bf
to
b6d055f
Compare
|
Check out the comments here #30408 Thanks for your contribution anyway! |
|
@rjl493456442 Though the performance optimization is negligible, I think it improves read ability. Otherwise someone may spot the same problem again in future. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These variables are only referenced in the
elsebranch.