p2p/discover: fix out-of-bounds slicing for chunked neighbors packets #966
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The code assumed that Table.closest always returns at least 13 nodes. This is not true for small tables (e.g. during bootstrap).
fjl
force-pushed
the
fixup-discover-chunked-neighbors
branch
from
1a7e805
to
251846d
Compare
fjl
added a commit
that referenced
this pull request
May 13, 2015
p2p/discover: fix out-of-bounds slicing for chunked neighbors packets
tony-ricciardi
pushed a commit
to tony-ricciardi/go-ethereum
that referenced
this pull request
Jan 20, 2022
tony-ricciardi
pushed a commit
to tony-ricciardi/go-ethereum
that referenced
this pull request
Jan 20, 2022
* started working on builtin network flags * lint * Don't aggregate epochSnarkData on non-epoch blocks (ethereum#961) * don't aggregate epochSnarkData on non-epoch blocks * uses existing proposal instead of re-fetching * change log levels for two side chain scenarios (ethereum#966) * Shorter timeouts for testing key rotation (ethereum#954) * working * Use Gold.mint() instead of state.AddBalance() for epoch rewards (ethereum#965) The rationale behind this, is the `Gold.mint()` emits an event, and thus is traceable, while `state.AddBalance()` is not. Making it really hard to figure out how much GoldToken was minted and to whom. * combining these * compiles * Restore master as circle-ci branch (ethereum#967) * Update version to v1.0.0-unstable (ethereum#970) * Add Mergify config and remove bulldozer config (ethereum#977) * Fix missing reference to libbls_crypto causing linking errors on iOS (ethereum#978) * Change proxy and proxied checks (ethereum#971) * Delete gitignore so libs are included (ethereum#980) * working??? * cleanup * cleanup * cleanup * write genesis correctly * trying to get unit tests working * changing this * lint * added mainnet info (execpt bootnode?) * added bootnode * fixing tests * lint * fix * fixing attach command * removing snapshots Co-authored-by: Kobi Gurkan <[email protected]> Co-authored-by: Victor "Nate" Graf <[email protected]> Co-authored-by: Mariano Cortesi <[email protected]> Co-authored-by: J M Rossy <[email protected]> Co-authored-by: Jean Regisser <[email protected]> Co-authored-by: Javier Cortejoso <[email protected]> Co-authored-by: Connor McEwen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code assumed that
Table.closestalways returns at least 13 nodes.This is not true for small tables (e.g. during bootstrap).