simulators/eth2/engine: Implement EL mock to test CLs #540
Conversation
| return fmt.Sprintf("http://%v:%d", p.IP, p.port), nil | ||
| } | ||
|
|
||
| func (p *Proxy) AddRequest(spoof *proxy.Spoof) { |
There was a problem hiding this comment.
I think it would be great to have the option to add a callback, something like func (p *Proxy) AddRequestCallback(callback func(interface{}) *proxy.Spoof) , and the callback function receives the request and you can respond on a request-by-request basis whether to spoof or not.
I think at the moment AddRequests spoofs every single request it receives from the CL which is ok, but being able to decide on which requests to spoof would let us fine-tune the test cases. E.g. a test case where only the transition payload is corrupted, but every payload after that is ok.
There was a problem hiding this comment.
Yes, I thought about this too, but unfortunately raul's proxy does not support that. I can try to implement it in the proxy so we can use it in hive eventually
There was a problem hiding this comment.
I've added a PR to raul's repo to add this functionality: rauljordan/engine-proxy#4
I haven't tested the changes but will do tomorrow.
| var engineAddrs []string | ||
| for _, index := range eth1Endpoints { | ||
| eth1Node := testnet.proxies[index] | ||
| userRPC, err := eth1Node.UserRPCAddress() |
There was a problem hiding this comment.
I had trouble using the UserRPCAddress of the proxy, I kept getting "the method net_version does not exist/is not available" errors.
I used testnet.eth1[index].UserRPCAddress for the userRPC and testnet.proxies[index] for engineRPC.
|
This looks good to me. I tested the callbacks from my PR in the proxy and it's working ok. There are a couple of changes required for the callbacks to work in this simulator, but we have to wait for my PR to be merged in Raul's engine-proxy. I can do these required changes in a later PR, or we can wait and incorporate them here, however you decide. |
|
I think it's okay |
This PR implements a new class of simulators used to test CL implementations. We start a proxy between EL and CL which allows us to modify requests and responses to and from the EL.