clients/go-ethereum: remove deprecated PoW #773
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fjl
changed the title
fjl
changed the title
holiman
reviewed
May 4, 2023
Comment on lines
-4
to
-8
| RUN \ | ||
| /usr/local/bin/geth makecache 1 /ethash && \ | ||
| /usr/local/bin/geth makecache 30000 /ethash && \ | ||
| /usr/local/bin/geth makedag 1 /ethash && \ | ||
| /usr/local/bin/geth makedag 30000 /ethash |
There was a problem hiding this comment.
I believe we can skip the line above too, and also L24 COPY --from=geth /ethash /ethash
There was a problem hiding this comment.
Ah I forgot to push this. Thanks for fixing
An alternative solution is to re-add the Fakepow is basically ethash but without verifying the PoW This PR will instead accept "invalid difficulty chain" due to the |
|
I still hadn't a chance to look at every simulation but un-drafted for now. This will at least fix CI for other PRs. |
mattsse
pushed a commit
to paradigmxyz/hive
that referenced
this pull request
May 12, 2023
* simulators/ethereum/engine: send `eth_` requests to port 8545 (ethereum#752) simulators/ethereum/engine: send `eth_` requests to 8545 * clients/ethereumjs: Update branch (ethereum#753) * clients/ethereumjs: Change git branch * clients/ethereumjs: Fix bash script issues * simulators/ethereum/engine: node: unsubscribe from events * simulators/ethereum/engine: clmock: add extra logs * simulators/ethereum/engine: correctly stop secondary clients * simulators/eth2/common: create client interfaces, update mock builder (ethereum#738) * simulators/eth2/common: refactor clients * simulators/eth2/engine: fixes due to refactor * simulators/eth2/common: builder: invalidate payloads * simulators/eth2/common: builder readme * simulators/eth2/common: builder: add option to build a payload on an outdated version * simulators/eth2/withdrawals: add invalid built payload version test * simulators/eth2/common: builder: remove check to build invalid payload * simulators/eth2/withdrawals: Fix check * simulators/eth2/withdrawals: test case validation * simulators/eth2/common: builder: fix invalidation * simulators/eth2/withdrawals: fix verifications again * simulators/ethereum/pyspec: Comment Dockerfile to run local fixtures (ethereum#755) simulators/ethereum/pyspec: Add Dockerfile comment to run locally generated fixtures * clients/besu: add --data-storage-format=BONSAI (ethereum#758) * simulators/ethereum/engine: Unique Payload ID Tests (ethereum#757) * simulators/ethereum/engine: expose generic fcu, np * simulators/ethereum/engine: Unique payload id test * simulators/ethereum/engine: Add payload id test * simulators/ethereum/engine: Parallel getPayloadBodies Test (ethereum#749) * simulators/ethereum/engine: parallel getpayloadbodies * simulators/ethereum/withdrawals: readme * clients/erigon: --externalcl flag is not supported anymore (ethereum#760) * graphql: consistent rule for Long outputs and args (ethereum#746) * simulators/eth2: Verify block signatures on blocks sent to builder (ethereum#756) * simulators/eth2/common/builder: interfaces changes * simulators/eth2/common/builder: verify signatures * simulators/eth2/withdrawals: Verify block signatures * simulators/eth2/withdrawals: Update README * simulators/eth2/withdrawals: minor nit comment * clients/erigon: explicit --db.size.limit value (ethereum#766) * clients/nethermind: Cancun support (ethereum#762) * clients/nethermind: Cancun Support * clients/nethermind: Dockerfile args * clients/besu: Cancun Support (ethereum#769) * clients/ethereumjs: Cancun Support (ethereum#768) clients/ethereumjs: Cancun Support. * clients/go-ethereum: remove deprecated PoW (ethereum#773) Remove ethash-related flags and utils from go-ethereum, since they were deprecated upstream. --------- Co-authored-by: Martin Holst Swende <[email protected]> * clients/nethermind: Add excessDataGas to genesis mapper. (ethereum#771) * sim/pyspec: bubble error (ethereum#777) * simulators/devp2p: fix issue causing ethereumjs to crash (ethereum#778) sim/devp2p: fix issue causing ethereumjs to crash It seems ethereumjs crashes if the chainid is not present in the genesis. --------- Co-authored-by: Mario Vega <[email protected]> Co-authored-by: Gabriel Fukushima <[email protected]> Co-authored-by: Andrew Ashikhmin <[email protected]> Co-authored-by: Sina Mahmoodi <[email protected]> Co-authored-by: Spencer Taylor-Brown <[email protected]> Co-authored-by: Martin Holst Swende <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Geth PoW mining and real verification, and as a result many of the utilities used in tests such as makecache makedag etc.
The
--fakepowflag is also removed. Now a merge-ready network is required and in that case a PoW fake verifier will be available. To trigger this we set"terminalTotalDifficultyPassed": true.ethereum/go-ethereum#27178