Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for installing 0.4.x version of Solidity #221

Merged
merged 1 commit into from
Mar 21, 2019
Merged

Conversation

ChrisChinchilla
Copy link
Contributor

No description provided.

@ChrisChinchilla
Copy link
Contributor Author

So we can trigger tests (which passed), I created a new PR here that combines #219 and #212

@ChrisChinchilla ChrisChinchilla force-pushed the ver-test-2 branch 2 times, most recently from 47cdfd5 to 6f6123c Compare March 18, 2019 11:35
@ChrisChinchilla ChrisChinchilla changed the title Ver test 2 Add support for installing 0.4.x version of Solidity Mar 18, 2019
@ChrisChinchilla
Copy link
Contributor Author

Merged everything together to one tidy(ish) PR @chriseth and @axic

sha256 "8172c126973eae1d9d6c7b5071910a9c7475ac64df3945f755cee66104add72d"

depends_on "cmake" => :build
depends_on "[email protected]" => "c++11"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this needing a specific version while 0.5.x doesn't?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This gets a little beyond my C++ knowledge, but iirc, something changed with the boost versions used recently, and if you build this version of Solidity with the latest version of boost, you get errors. When I researched those errors, it seemed that the change happened in recent boost versions, this is the closest Homebrew version of boost available that works with compiling this version of Solidity. You can try it if you like and see what I mean, but this fixed those build errors.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ekpyron @chriseth do you happen to know the reason? If we release 0.4.26 for fixing the Firefox inconvenience, we may as well fix this one.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know - 1.60 sounds a little old, too...

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well the Solidity cmake does check for the minimum supported version so this should be safe.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1.60 sounds a little old, too...

Keep in mind this is compiling 0.4.x which assumed 1.54 as a minimum.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chriseth and @axic These are sadly the version available - https://formulae.brew.sh/formula/boost

I couldn't get a build to work with the 1.69 version, but I am not sure why, I can share logs if need be. Or we know of a specific boost version that is newer, and does work, i can make a PR to their formula?

Copy link
Member

@axic axic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, except that one question.

@ChrisChinchilla
Copy link
Contributor Author

@axic Answered, and I'll update docs and issues accordingly when this is merged.

@axic
Copy link
Member

axic commented Mar 21, 2019

I'm merging this to have some progress. Created an issue to track: ethereum/solidity#6349

@axic axic merged commit 923565c into master Mar 21, 2019
@axic axic deleted the ver-test-2 branch March 21, 2019 17:25
@zulhfreelancer
Copy link

Thank you @ChrisChinchilla for this PR!

I wrote a guide here to share my steps how the downgrade process from 0.5.x to 0.4.x looks like.

https://link.medium.com/TLnfCI48fV

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants