-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for installing 0.4.x version of Solidity #221
Conversation
47cdfd5
to
6f6123c
Compare
6f6123c
to
9e694a2
Compare
sha256 "8172c126973eae1d9d6c7b5071910a9c7475ac64df3945f755cee66104add72d" | ||
|
||
depends_on "cmake" => :build | ||
depends_on "[email protected]" => "c++11" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this needing a specific version while 0.5.x
doesn't?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This gets a little beyond my C++ knowledge, but iirc, something changed with the boost versions used recently, and if you build this version of Solidity with the latest version of boost, you get errors. When I researched those errors, it seemed that the change happened in recent boost versions, this is the closest Homebrew version of boost available that works with compiling this version of Solidity. You can try it if you like and see what I mean, but this fixed those build errors.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know - 1.60 sounds a little old, too...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well the Solidity cmake does check for the minimum supported version so this should be safe.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1.60 sounds a little old, too...
Keep in mind this is compiling 0.4.x which assumed 1.54 as a minimum.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@chriseth and @axic These are sadly the version available - https://formulae.brew.sh/formula/boost
I couldn't get a build to work with the 1.69 version, but I am not sure why, I can share logs if need be. Or we know of a specific boost version that is newer, and does work, i can make a PR to their formula?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, except that one question.
@axic Answered, and I'll update docs and issues accordingly when this is merged. |
I'm merging this to have some progress. Created an issue to track: ethereum/solidity#6349 |
Thank you @ChrisChinchilla for this PR! I wrote a guide here to share my steps how the downgrade process from 0.5.x to 0.4.x looks like. |
No description provided.