-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove cpp-ethereum (and leave deprecation notice) #222
Conversation
cpp-ethereum.rb
Outdated
test do | ||
system "#{bin}/aleth", "--version" | ||
end | ||
odie "cpp-ethereum has been removed from Homebrew. Please install binary release from https://github.com/ethereum/aleth/relases" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left this message here because there's no direct way to mark removed/deprecated packages.
Homebrew only has two files:
formula_renames.json
for renamingtap_migrations.json
when a package moved to a different repository
Is it enough to just merge it now? |
@axic @chfast I think this PR borked something: ethereum/go-ethereum#19335 |
Looks like |
Whatever it was suppose to do, you can remove it. |
Weird, I must have had a different brew version because the change worked here. |
Closes #216. Closes #161.