Remove cpp-ethereum (and leave deprecation notice) #222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
axic
commented
Mar 24, 2019
cpp-ethereum.rb
Outdated
| test do | ||
| system "#{bin}/aleth", "--version" | ||
| end | ||
| odie "cpp-ethereum has been removed from Homebrew. Please install binary release from https://github.com/ethereum/aleth/relases" |
There was a problem hiding this comment.
Left this message here because there's no direct way to mark removed/deprecated packages.
Homebrew only has two files:
formula_renames.jsonfor renamingtap_migrations.jsonwhen a package moved to a different repository
chfast
requested changes
Mar 25, 2019
chfast
approved these changes
Mar 25, 2019
|
Is it enough to just merge it now? |
|
@axic @chfast I think this PR borked something: ethereum/go-ethereum#19335 |
|
Looks like |
|
Whatever it was suppose to do, you can remove it. |
|
Weird, I must have had a different brew version because the change worked here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #216. Closes #161.