Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix running builds on CircleCI #282

Merged
merged 2 commits into from
Dec 16, 2020
Merged

Fix running builds on CircleCI #282

merged 2 commits into from
Dec 16, 2020

Conversation

axic
Copy link
Member

@axic axic commented Nov 19, 2020

@axic axic requested a review from chriseth November 19, 2020 23:19
@chriseth
Copy link
Contributor

Not fixed.

@axic
Copy link
Member Author

axic commented Nov 23, 2020

Did you even had a look at the logs or just said "not fixed"?

The original issue is fixed, which was that using URL with install doesn't work anymore.

0.7, 0.7, 0.5 compile. Apparently now 0.4 fails to compile:

[ 94%] Linking CXX static library libsolidity.a
cd /tmp/solidity@4-20201119-6976-1xizyrh/solidity_0.4.26/libsolidity && /usr/local/Cellar/cmake/3.19.0/bin/cmake -P CMakeFiles/solidity.dir/cmake_clean_target.cmake
cd /tmp/solidity@4-20201119-6976-1xizyrh/solidity_0.4.26/libsolidity && /usr/local/Cellar/cmake/3.19.0/bin/cmake -E cmake_link_script CMakeFiles/solidity.dir/link.txt --verbose=1
/usr/bin/ar qc libsolidity.a CMakeFiles/solidity.dir/__/libjulia/backends/evm/EVMAssembly.cpp.o CMakeFiles/solidity.dir/__/libjulia/backends/evm/EVMCodeTransform.cpp.o CMakeFiles/solidity.dir/__/libjulia/optimiser/ASTCopier.cpp.o CMakeFiles/solidity.dir/__/libjulia/optimiser/ASTWalker.cpp.o CMakeFiles/solidity.dir/__/libjulia/optimiser/CommonSubexpressionEliminator.cpp.o CMakeFiles/solidity.dir/__/libjulia/optimiser/DataFlowAnalyzer.cpp.o CMakeFiles/solidity.dir/__/libjulia/optimiser/Disambiguator.cpp.o CMakeFiles/solidity.dir/__/libjulia/optimiser/ExpressionInliner.cpp.o CMakeFiles/solidity.dir/__/libjulia/optimiser/ExpressionSimplifier.cpp.o CMakeFiles/solidity.dir/__/libjulia/optimiser/FullInliner.cpp.o CMakeFiles/solidity.dir/__/libjulia/optimiser/FunctionGrouper.cpp.o CMakeFiles/solidity.dir/__/libjulia/optimiser/FunctionHoister.cpp.o CMakeFiles/solidity.dir/__/libjulia/optimiser/InlinableExpressionFunctionFinder.cpp.o CMakeFiles/solidity.dir/__/libjulia/optimiser/MainFunction.cpp.o CMakeFiles/solidity.dir/__/libjulia/optimiser/Metrics.cpp.o CMakeFiles/solidity.dir/__/libjulia/optimiser/NameCollector.cpp.o CMakeFiles/solidity.dir/__/libjulia/optimiser/NameDispenser.cpp.o CMakeFiles/solidity.dir/__/libjulia/optimiser/Rematerialiser.cpp.o CMakeFiles/solidity.dir/__/libjulia/optimiser/Semantics.cpp.o CMakeFiles/solidity.dir/__/libjulia/optimiser/SimplificationRules.cpp.o CMakeFiles/solidity.dir/__/libjulia/optimiser/Substitution.cpp.o CMakeFiles/solidity.dir/__/libjulia/optimiser/SyntacticalEquality.cpp.o CMakeFiles/solidity.dir/__/libjulia/optimiser/UnusedPruner.cpp.o CMakeFiles/solidity.dir/__/libjulia/optimiser/Utilities.cpp.o CMakeFiles/solidity.dir/analysis/ConstantEvaluator.cpp.o CMakeFiles/solidity.dir/analysis/ControlFlowAnalyzer.cpp.o CMakeFiles/solidity.dir/analysis/ControlFlowBuilder.cpp.o CMakeFiles/solidity.dir/analysis/ControlFlowGraph.cpp.o CMakeFiles/solidity.dir/analysis/DeclarationContainer.cpp.o CMakeFiles/solidity.dir/analysis/DocStringAnalyser.cpp.o CMakeFiles/solidity.dir/analysis/GlobalContext.cpp.o CMakeFiles/solidity.dir/analysis/NameAndTypeResolver.cpp.o CMakeFiles/solidity.dir/analysis/PostTypeChecker.cpp.o CMakeFiles/solidity.dir/analysis/ReferencesResolver.cpp.o CMakeFiles/solidity.dir/analysis/SemVerHandler.cpp.o CMakeFiles/solidity.dir/analysis/StaticAnalyzer.cpp.o CMakeFiles/solidity.dir/analysis/SyntaxChecker.cpp.o CMakeFiles/solidity.dir/analysis/TypeChecker.cpp.o CMakeFiles/solidity.dir/analysis/ViewPureChecker.cpp.o CMakeFiles/solidity.dir/ast/AST.cpp.o CMakeFiles/solidity.dir/ast/ASTAnnotations.cpp.o CMakeFiles/solidity.dir/ast/ASTJsonConverter.cpp.o CMakeFiles/solidity.dir/ast/ASTPrinter.cpp.o CMakeFiles/solidity.dir/ast/ASTUtils.cpp.o CMakeFiles/solidity.dir/ast/Types.cpp.o CMakeFiles/solidity.dir/codegen/ABIFunctions.cpp.o CMakeFiles/solidity.dir/codegen/ArrayUtils.cpp.o CMakeFiles/solidity.dir/codegen/Compiler.cpp.o CMakeFiles/solidity.dir/codegen/CompilerContext.cpp.o CMakeFiles/solidity.dir/codegen/CompilerUtils.cpp.o CMakeFiles/solidity.dir/codegen/ContractCompiler.cpp.o CMakeFiles/solidity.dir/codegen/ExpressionCompiler.cpp.o CMakeFiles/solidity.dir/codegen/LValue.cpp.o CMakeFiles/solidity.dir/formal/SMTChecker.cpp.o CMakeFiles/solidity.dir/formal/SMTLib2Interface.cpp.o CMakeFiles/solidity.dir/formal/SSAVariable.cpp.o CMakeFiles/solidity.dir/formal/SymbolicBoolVariable.cpp.o CMakeFiles/solidity.dir/formal/SymbolicIntVariable.cpp.o CMakeFiles/solidity.dir/formal/SymbolicVariable.cpp.o CMakeFiles/solidity.dir/formal/VariableUsage.cpp.o CMakeFiles/solidity.dir/formal/Z3Interface.cpp.o CMakeFiles/solidity.dir/inlineasm/AsmAnalysis.cpp.o CMakeFiles/solidity.dir/inlineasm/AsmAnalysisInfo.cpp.o CMakeFiles/solidity.dir/inlineasm/AsmCodeGen.cpp.o CMakeFiles/solidity.dir/inlineasm/AsmParser.cpp.o CMakeFiles/solidity.dir/inlineasm/AsmPrinter.cpp.o CMakeFiles/solidity.dir/inlineasm/AsmScope.cpp.o CMakeFiles/solidity.dir/inlineasm/AsmScopeFiller.cpp.o CMakeFiles/solidity.dir/interface/ABI.cpp.o CMakeFiles/solidity.dir/interface/AssemblyStack.cpp.o CMakeFiles/solidity.dir/interface/CompilerStack.cpp.o CMakeFiles/solidity.dir/interface/ErrorReporter.cpp.o CMakeFiles/solidity.dir/interface/Exceptions.cpp.o CMakeFiles/solidity.dir/interface/GasEstimator.cpp.o CMakeFiles/solidity.dir/interface/Natspec.cpp.o CMakeFiles/solidity.dir/interface/SourceReferenceFormatter.cpp.o CMakeFiles/solidity.dir/interface/StandardCompiler.cpp.o CMakeFiles/solidity.dir/interface/Version.cpp.o CMakeFiles/solidity.dir/parsing/DocStringParser.cpp.o CMakeFiles/solidity.dir/parsing/Parser.cpp.o CMakeFiles/solidity.dir/parsing/ParserBase.cpp.o CMakeFiles/solidity.dir/parsing/Scanner.cpp.o CMakeFiles/solidity.dir/parsing/Token.cpp.o
/Applications/Xcode-11.4.1.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: libsolidity.a(AsmAnalysisInfo.cpp.o) has no symbols
/usr/bin/ranlib libsolidity.a
/Applications/Xcode-11.4.1.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: libsolidity.a(AsmAnalysisInfo.cpp.o) has no symbols
[ 94%] Built target solidity
make: *** [all] Error 2
``

@chriseth
Copy link
Contributor

Yes, I did look at the logs. AsmAnalysisInfo.cpp does not have any code ,right?

@chriseth chriseth merged commit d1065e9 into master Dec 16, 2020
@chriseth chriseth deleted the ci branch December 16, 2020 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants