Pass bytes instead of string to web3.eth.sign in is_account_locked() #478
Conversation
populus/utils/accounts.py
Outdated
| @@ -12,7 +13,7 @@ def is_account_locked(web3, account): | |||
| if isinstance(web3.providers[0], EthereumTesterProvider): | |||
| return not any((is_same_address(account, a) for a in web3.eth.accounts[:10])) | |||
| try: | |||
| web3.eth.sign(account, 'simple-test-data') | |||
| web3.eth.sign(account, to_bytes(text='simple-test-data')) | |||
There was a problem hiding this comment.
to_bytes is not needed here, use text param in web3.eth.sign instead.
Just do web3.eth.sign(w3.eth.accounts[1], text='simple-test-data')
|
Ideally, would have loved to see a test for this, but Thanks, @JulianLiu for fixing this. I have made some minor adjustments to your PR. I will merge this as soon as master turns green. |
|
All python3.5 tests are failing, could be related to ethereum/web3.py#921. Will look into this tomorrow. |
|
Failing test taken care in #480 |
|
@JulianLiu I accidentally closed your PR, while trying to rebase changes I made to your PR. I have opened a new PR #481 with your commit cherry-picked. |
|
@voith No worries. Thank you for the update :) |
What was wrong?
to_hex() in eth-utils no longer accept string as a primitive (ref: commit), it will fail if data parameter is passed as str to web3.eth.sign
How was it fixed?
Convert string 'simple-test-data' to bytes before passing to web3.eth.sign
Cute Animal Picture