-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Python 3 Support #102
Python 3 Support #102
Conversation
This PR should resolve the following issues.
|
@vbuterin could you take a look at this? Potentially enable travis-ci on this repo and let me know what's needed to get this merged. |
basepython=python3.4 | ||
|
||
[testenv:py35] | ||
basepython=python3.5 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These basepython
declarations shouldn't be needed anymore for non-ancient versions of Tox.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Neat, I didn't know that. fixed.
@pipermerriam The ethereum/serpent repo has been activated on Travis |
8dd43f9
to
bc4ce59
Compare
ok, looks like the test failures are related to not having python3 in |
Just noting that the tests for this pass when run against the pyethereum branch with python 3 support. See #103 |
be90782
to
4501e9a
Compare
What was wrong?
print
statement that isn't python 3 compatable.market.se
contract needed to be updated to the new extern format (see compilation error on cyberdyne market example #85)How was it fixed?
.travis.yml
andtox.ini
file.extern
statements to be correct.Cute animal picture