Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python 3 Support #102

Merged
merged 9 commits into from
Jun 22, 2016
Merged

Conversation

pipermerriam
Copy link
Member

@pipermerriam pipermerriam commented Jun 15, 2016

What was wrong?

  • Travis CI is not enabled
  • There was a print statement that isn't python 3 compatable.
  • The market.se contract needed to be updated to the new extern format (see compilation error on cyberdyne market example #85)
  • The package didn't specify anything about what versions of python it is compatable with.
  • No python3 support.
  • The README was very sparse in general information about the package.

How was it fixed?

  • Added a basic .travis.yml and tox.ini file.
  • Converted the print statement to be python3 compatable.
  • Redid the extern statements to be correct.
  • Added classifiers for python 2.7/3.4/3.5
  • Added info to the README on how to run the tests.

Cute animal picture

f55a1348d24098a680f5f4ff3838dca5

@pipermerriam
Copy link
Member Author

This PR should resolve the following issues.

@pipermerriam
Copy link
Member Author

@vbuterin could you take a look at this? Potentially enable travis-ci on this repo and let me know what's needed to get this merged.

basepython=python3.4

[testenv:py35]
basepython=python3.5

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These basepython declarations shouldn't be needed anymore for non-ancient versions of Tox.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat, I didn't know that. fixed.

@pipermerriam
Copy link
Member Author

pipermerriam commented Jun 17, 2016

@tgerring I was told that you might be able to enable travis-ci for this repository? Also, looking for someone who has merge permissions. I got the 👍 from @vbuterin over skype.

I'd like to see tests passing on travis prior to merging though.

@tgerring
Copy link

@pipermerriam The ethereum/serpent repo has been activated on Travis

@pipermerriam
Copy link
Member Author

ok, looks like the test failures are related to not having python3 in pyethereum. I'm going to deal with this on the pyethereum side and then we'll get this merged.

@pipermerriam
Copy link
Member Author

Just noting that the tests for this pass when run against the pyethereum branch with python 3 support. See #103

@pipermerriam pipermerriam changed the title Piper/add travis ci testing Python 3 Support Jun 21, 2016
@vbuterin vbuterin merged commit 9dc8c1c into ethereum:develop Jun 22, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants