Update cvc4 to cvc5 #741
Merged
Update cvc4 to cvc5 #741
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blishko
reviewed
Jun 20, 2024
No, I have not done that, but we could indeed add some CI tests. However, even z3 is not currently tested (see: https://github.com/ethereum/solc-js/blob/master/test/smtchecker.ts#L64). Therefore, I'm not sure if it's worth adding them in this PR. We could consider adding tests for all solvers in a subsequent PR. |
r0qs
force-pushed
the
update-cvc4-to-cvc5
branch
from
2600e27
to
3ba9758
Compare
|
OK, let's see if we can add some tests in another PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on ethereum/solidity#15078