Prefer authenticated request to github api when the token is available #14263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
r0qs
commented
May 24, 2023
cameel
previously approved these changes
May 25, 2023
Co-authored-by: Kamil Śliwak <[email protected]>
r0qs
force-pushed
the
gh-auth-token-foundry-cmd
branch
from
34f6695
to
f09838a
Compare
cameel
approved these changes
May 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR #14242 changed the
install_foundrycommand to perform authenticated requests to the Github API when querying the foundry release SHA hash, since unauthenticated requests have a lower limit of requests per hour, which was causing intermittent failures.However, external contributors do not have access to the GITHUB_ACCESS_TOKEN environment variable set in the CircleCI project settings, and thus fail to perform the authenticated request to the Github API:
https://app.circleci.com/pipelines/github/ethereum/solidity/29901/workflows/d2d574cb-6624-486f-904b-598b20118606/jobs/1328298
This PR changes the previous behavior to only add the
Authorizationheader when the GITHUB_ACCESS_TOKEN is available.