Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Yul AST IDs should start from 0 instead of 1. #14455

Merged
merged 1 commit into from
Aug 1, 2023
Merged

Yul AST IDs should start from 0 instead of 1. #14455

merged 1 commit into from
Aug 1, 2023

Conversation

r0qs
Copy link
Member

@r0qs r0qs commented Jul 28, 2023

Fixes #14453.

cameel
cameel approved these changes Aug 1, 2023
View reviewed changes
Copy link
Member

@cameel cameel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ekpyron ekpyron merged commit 2c70255 into develop Aug 1, 2023
1 check passed
@ekpyron ekpyron deleted the fix-yul-id branch August 1, 2023 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cameel cameel cameel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Yul sources are given id 1 instead of 0 in compiler output (inconsistent with source map & ast)
3 participants
@r0qs @cameel @ekpyron