Do not crash when trying to encode too large arrays

[erak]

Fixes #5058.

[chriseth]

Wouldn't it be better to call arrayBaseType->validForCalldata() here?
A counterexample could be uint[2**30][2**30][]

[erak]

Not calling arrayBaseType->validForCalldata() would still result in an assertion for function f(uint[2**30][2**30][] memory) public pure {}. The same code does not assert when ABIEncoderV2is enabled.

[chriseth]

Sorry, I'm still puzzled. I was suggesting to call arrayBaseType->validForCalldata(); regardless of the base type and returning false if it returned false. As it is now, we do not check the encoded size, which means something like [2**16][2**16] would not be caught, I think.

[codecov]

Codecov Report

Merging #5188 into develop will increase coverage by <.01%.
The diff coverage is 50%.

@@             Coverage Diff             @@
##           develop    #5188      +/-   ##
===========================================
+ Coverage    88.01%   88.01%   +<.01%     
===========================================
  Files          322      318       -4     
  Lines        32489    31909     -580     
  Branches      3863     3766      -97     
===========================================
- Hits         28594    28086     -508     
+ Misses        2592     2551      -41     
+ Partials      1303     1272      -31

Flag	Coverage Δ
#all	88.01% <50%> (ø)	⬆️
#syntax	28.69% <50%> (+0.78%)	⬆️