This repository has been archived by the owner on Jul 1, 2021. It is now read-only.
Disable resolver in dockerfile for consistent builds #2090
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
njgheorghita
force-pushed
the
improve-ci-docker-build
branch
2 times, most recently
from
72817b7
to
76c8bc4
Compare
njgheorghita
changed the title
njgheorghita
force-pushed
the
improve-ci-docker-build
branch
from
76c8bc4
to
548f778
Compare
njgheorghita
changed the title
njgheorghita
force-pushed
the
improve-ci-docker-build
branch
from
548f778
to
778fdc9
Compare
|
Flaky is definitely bad, so I agree that doing nothing is not the best resolution. I have had experiences where the only way to install it correctly was to use the new resolver. As long as it's green, I'm fine with it for now. The behavior will be default soon enough. |
Ok, cool - yeah it seems like that's no longer the case. Do you think it's worth leaving a note? When you first introduced the flag - how obvious of a fix was it to introduce the flag? |
|
It wasn't totally obvious, but since it will be the default soon, we don't have to spend too much time on it. |
|
Cool, i'll merge this in if you can give the official 👍 |
carver
approved these changes
Oct 22, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
The
docker-trinity-image-build-testCI run has been consistently flaky for me recently.It seems to me that the problem is similar to the one described in this issue - where essentially the
--use-feature=2020-resolverpytest flag is very slow and inefficient. I've seen multiple instances of the resolver installing many different versions of the same dependency while trying to resolve the dependency tree. This poor performance is acknowledged and is under active improvements by the pip team. Thedocker-trinity-image-build-testconsistently times out during the install step with the2020-resolverenabled.The pip team has already released some improvements to the resolver in
pip==20.2.4, but it seems like whatever improvements were included in20.2.4are not sufficient to prevent timeouts in the docker install step. They intend to release further improvements in20.3.How was it fixed?
The solution here is to just remove the
--use-feature=2020-resolverflag for the time being. This results in consistently quick & passing CI tests.To-Do
Cute Animal Picture