This repository has been archived by the owner on Jul 1, 2021. It is now read-only.
Fix attestation, previous epoch logic and builder tools #300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Fix `create_mock_signed_attestation`: Address ethereum/consensus-specs#671 2. Fix `test_demo.py` 1. Use queued `attestations_map: Dict[Slot, Sequence[Attestation]]` to keep the generated attestations, and include them when reache `MIN_ATTESTATION_INCLUSION_DELAY`. 2. Add justification assertions
ChihChengLiang
approved these changes
Feb 22, 2019
tests/eth2/beacon/state_machines/forks/test_serenity_block_attestation_validation.py
Outdated
Show resolved
Hide resolved
djrtwo
approved these changes
Feb 22, 2019
NIC619
approved these changes
Feb 22, 2019
tests/eth2/beacon/conftest.py
Outdated
| Rationales: | ||
| 1. Making the privkeys be small integers to make multiplying easier for tests. | ||
| 2. Using ``2**i`` instead of ``i``: | ||
| The combinations of validators would not lead to unique pubkeys. |
There was a problem hiding this comment.
Should it be ...would lead to unique pubkeys?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
To fix #294, also need to fix other issues to make
test_demo.pywork.How was it fixed?
create_mock_signed_attestation: Address validator guide bug fixes consensus-specs#671test_demo.pyattestations_map: Dict[Slot, Sequence[Attestation]]to keep the generated attestations, and include them when reacheMIN_ATTESTATION_INCLUSION_DELAY.Cute Animal Picture
(Foto: Heike Katthagen)