PR feedback

web3/manager.py

@@ -104,9 +104,9 @@ def request_blocking(self, method, params, error_formatters=None):
         Make a synchronous request using the provider
         """
         response = self._make_request(method, params)
-        apply_error_formatters(error_formatters, response)
 
         if "error" in response:
+            apply_error_formatters(error_formatters, response)
             raise ValueError(response["error"])
 
         return response['result']
@@ -116,9 +116,9 @@ async def coro_request(self, method, params, error_formatters=None):
         Couroutine for making a request using the provider
         """
         response = await self._coro_make_request(method, params)
-        apply_error_formatters(error_formatters, response)
 
         if "error" in response:
+            apply_error_formatters(error_formatters, response)
             raise ValueError(response["error"])
 
         if response['result'] is None:

web3/method.py

@@ -114,6 +114,13 @@ def method_selector_fn(self):
         raise ValueError("``json_rpc_method`` config invalid.  May be a string or function")
 
     def input_munger(self, module, args, kwargs):
+        # This function takes the "root_munger" - the first munger in
+        # the list of mungers) and then pipes the return value of the
+        # previous munger as an argument to the next munger to return
+        # an array of arguments that have been formatted.
+        # See the test_process_params test
+        # in tests/core/method-class/test_method.py for an example
+        # with multiple mungers.
         # TODO: Create friendly error output.
         mungers_iter = iter(self.mungers)
         root_munger = next(mungers_iter)