snakecase traceReplayTransaction

ethereum · Apr 23, 2021 · c688e2a · c688e2a
1 parent bd6d24c
commit c688e2a
Show file tree

Hide file tree

Showing 3 changed files with 21 additions and 2 deletions.
diff --git a/newsfragments/1949.feature.rst b/newsfragments/1949.feature.rst
@@ -0,0 +1 @@
+Add trace_replay_transaction deprecate traceReplayTransaction
diff --git a/web3/_utils/module_testing/parity_module.py b/web3/_utils/module_testing/parity_module.py
@@ -31,11 +31,24 @@
 
 
 class ParityTraceModuleTest:
+    def test_traceReplayTransaction_deprecated(
+        self, web3: "Web3", parity_fixture_data: Dict[str, str],
+    ) -> None:
+        with pytest.warns(DeprecationWarning,
+                          match='traceReplayTransaction is deprecated in favor of '
+                                'trace_replay_transaction'):
+            trace = web3.parity.traceReplayTransaction(
+                HexStr(parity_fixture_data['mined_txn_hash']))
+        assert trace['stateDiff'] is None
+        assert trace['vmTrace'] is None
+        assert trace['trace'][0]['action']['from'] == add_0x_prefix(
+            HexStr(parity_fixture_data['coinbase']),
+        )
 
     def test_trace_replay_transaction(
         self, web3: "Web3", parity_fixture_data: Dict[str, str],
     ) -> None:
-        trace = web3.parity.traceReplayTransaction(HexStr(parity_fixture_data['mined_txn_hash']))
+        trace = web3.parity.trace_replay_transaction(HexStr(parity_fixture_data['mined_txn_hash']))
 
         assert trace['stateDiff'] is None
         assert trace['vmTrace'] is None

diff --git a/web3/parity.py b/web3/parity.py
@@ -41,6 +41,7 @@
     RPC,
 )
 from web3.method import (
+    DeprecatedMethod,
     Method,
     default_root_munger,
 )
@@ -153,7 +154,7 @@ def trace_replay_transaction_munger(
     ) -> Tuple[Union[BlockIdentifier, _Hash32], ParityTraceMode]:
         return (block_identifier, mode)
 
-    traceReplayTransaction: Method[Callable[..., ParityBlockTrace]] = Method(
+    trace_replay_transaction: Method[Callable[..., ParityBlockTrace]] = Method(
         RPC.trace_replayTransaction,
         mungers=[trace_replay_transaction_munger],
     )
@@ -218,3 +219,7 @@ def trace_transactions_munger(
         RPC.parity_mode,
         mungers=None
     )
+
+    # Deprecated Methods
+    traceReplayTransaction = DeprecatedMethod(trace_replay_transaction, 'traceReplayTransaction',
+                                              'trace_replay_transaction')