Merge pull request #1546 from njgheorghita/typing-extensions-import

Remove mypy-extensions
ethereum · Dec 12, 2019 · e4b835e · e4b835e
2 parents f5fcaa6 + feb7428
commit e4b835e
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/newsfragments/1546.misc.rst b/newsfragments/1546.misc.rst
@@ -0,0 +1 @@
+Remove redundant mypy-extensions dependency.
diff --git a/setup.py b/setup.py
@@ -80,10 +80,9 @@
         "protobuf>=3.10.0,<4",
         "pypiwin32>=223;platform_system=='Windows'",
         "requests>=2.16.0,<3.0.0",
+        # remove typing_extensions after python_requires>=3.8, see web3._utils.compat
+         "typing-extensions>=3.7.4.1,<4;python_version<'3.8'",
         "websockets>=8.1.0,<9.0.0",
-        # remove mypy_extensions & typing-extensions after python_requires>=3.8
-        # see web3._utils.compat
-        "typing-extensions>=3.7.4.1,<4",
     ],
     setup_requires=['setuptools-markdown'],
     python_requires='>=3.6,<4',

diff --git a/web3/_utils/compat/__init__.py b/web3/_utils/compat/__init__.py
@@ -1,6 +1,6 @@
 import sys
 # remove once web3 supports python>=3.8
-# TypedDict was added to typing in 3.8
+# Types was added to typing in 3.8
 if sys.version_info >= (3, 8):
     from typing import Literal, Protocol, TypedDict
 else: