Upgrade Geth Test to 1.9.19 #1708
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kclowes
force-pushed
the
upgrade-integration-tests-geth-1918
branch
from
8222b40
to
9744f71
Compare
…egration-tests-geth-1918
kclowes
force-pushed
the
upgrade-integration-tests-geth-1918
branch
from
9744f71
to
46f6af7
Compare
kclowes
force-pushed
the
upgrade-integration-tests-geth-1918
branch
from
beaed96
to
8780cc3
Compare
kclowes
changed the title
wolovim
approved these changes
Aug 20, 2020
|
|
||
| with pytest.warns(DeprecationWarning): | ||
| stop = web3.geth.admin.stopRPC() | ||
| assert stop |
There was a problem hiding this comment.
assuming the rest of these start and stop functions return True, we can keep the pattern going
kclowes
force-pushed
the
upgrade-integration-tests-geth-1918
branch
from
c4eb1f8
to
93cb072
Compare
kclowes
force-pushed
the
upgrade-integration-tests-geth-1918
branch
from
93cb072
to
103908f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
We have a PR up to handle
reverts that needs a newer version of Geth than what we currently test against. Upgrading will make that PR easier to implement/test. Not to mention that the Geth team only supports the latest version.Related to Issue #1585
How was it fixed?
Upgraded Geth versions and updated tests accordingly.
Todo:
Cute Animal Picture