Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flaky Geth websocket tests #1719

Closed
kclowes opened this issue Aug 26, 2020 · 2 comments · Fixed by #1724
Closed

Flaky Geth websocket tests #1719

kclowes opened this issue Aug 26, 2020 · 2 comments · Fixed by #1724

Comments

@kclowes
Copy link
Collaborator

kclowes commented Aug 26, 2020

What was wrong?

This PR introduced flaky tests in the Geth Websocket module.
Failures look like: https://app.circleci.com/pipelines/github/ethereum/web3.py/331/workflows/b033c86b-528a-47eb-a699-44027cb1e46b/jobs/122605
@carver carver linked a pull request Sep 2, 2020 that will close this issue
Upgrade eth-account and eth-tester #1724
Merged
1 task
@kclowes kclowes reopened this Sep 2, 2020
@carver
Copy link
Collaborator

carver commented Sep 2, 2020

Oops, didn't realize that linking it from the PR would auto-close it on the merge (without the "close" tag)... weird.

@kclowes
Copy link
Collaborator Author

kclowes commented Sep 2, 2020

Yeah, super weird. At first I thought you just figured it out really quickly 😆

@kclowes kclowes mentioned this issue Sep 3, 2020
Merged
1 task
@fselmo fselmo closed this as completed Sep 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Upgrade eth-account and eth-tester carver/web3.py
3 participants
@carver @fselmo @kclowes