Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade eth-account and eth-tester #1724

Merged
merged 2 commits into from
Sep 2, 2020
Merged

Conversation

carver
Copy link
Collaborator

@carver carver commented Aug 31, 2020

Pushing the libraries that support the latest pyrlp.

Todo:

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

@carver carver force-pushed the upgrade-deps branch 2 times, most recently from a33603d to 6fb95c7 Compare August 31, 2020 23:31
@carver
Copy link
Collaborator Author

carver commented Aug 31, 2020

@kclowes I assume you wanted the eth-utils out to merge into web3. I think it's getting side-loaded by these eth-tester and eth-account upgrades. Just a heads up that I'm doing the work to get the latest eth-utils working on web3.

@carver
Copy link
Collaborator Author

carver commented Aug 31, 2020

Have the integration tests been flaky, or do you think it's worth investigating a real break in py36-integration-goethereum-ws-1.9.19?

Copy link
Collaborator

@kclowes kclowes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you! The Geth websocket tests have been flaky unfortunately. I thought we had an issue to track it, but I don't see it so I'll add one (Edit: it's issue #1719)! 🚢

@carver carver linked an issue Sep 2, 2020 that may be closed by this pull request
@carver carver merged commit ad4772f into ethereum:master Sep 2, 2020
@carver carver deleted the upgrade-deps branch September 2, 2020 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Flaky Geth websocket tests
2 participants