Handle Flaky Geth WS Tests #1727
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kclowes
force-pushed
the
flaky-geth-ws-tests
branch
from
935134e
to
0ab8bf6
Compare
kclowes
force-pushed
the
flaky-geth-ws-tests
branch
from
6ca6c5e
to
84e1a4a
Compare
wolovim
approved these changes
Sep 3, 2020
There was a problem hiding this comment.
Manual testing of both start and stop methods worked as expected. Agree that these tests can be revisited and aren't highest priority.
My naive theory is just to stuff both the rpc and ws start and stop methods in one test to ensure a given state. Can test that and other uninformed theories separately, though.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
Since we updated the version of Geth that integration tests run against, the start/stop websocket and start/stop_rpc tests periodically cause all tests after them to fail, but only on CI. I suspect it has something to with the port, or setup/teardown between tests but couldn't figure the exact problem out, and feel that there is a diminishing return in spending more time on it. It does work as expected when checked manually.
Related to Issue #1719
How was it fixed?
Just added an xfail for now :(
Todo:
Cute Animal Picture