converting staticmethod calls to the proper decorator usage. #1979
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm fine with this change. Let me know if you want me to take over fixing the types @bschnurr! |
|
sure. that would be great. I was working on windows and didn't have everything quite working. |
kclowes
force-pushed
the
fix-staticmethod-signatures
branch
from
1aa0f81
to
2bdeeae
Compare
this was preventing the correct call signature to be displayed in pylance/pyright
kclowes
force-pushed
the
fix-staticmethod-signatures
branch
from
2bdeeae
to
a0dce31
Compare
kclowes
approved these changes
May 14, 2021
|
the |
|
Good call! Added! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this was preventing the correct call signature to be displayed in pylance/pyright
What was wrong?
Related to Issue #
microsoft/pylance-release#1210
How was it fixed?
looking at the description in builtins.pyi
changed the usage from assigning a function to a class member variable to the proper form of defining a new functions and using
@staticmethodas a decorator.One downside is missing docstrings.
Todo:
Cute Animal Picture