Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

explicitly add output_values to compile_source example #2293

Merged
merged 1 commit into from
Jan 7, 2022

Conversation

pacrob
Copy link
Contributor

@pacrob pacrob commented Jan 7, 2022

What was wrong?

A change from solc (see here) caused our contracts example to break.

How was it fixed?

Explicitly defining the output_values fixes our example without waiting for py-solc-x to fix it on their end and makes it more clear where we get those values later in the example.

Todo:

Cute Animal Picture

image

@pacrob pacrob force-pushed the update_docs_contracts_example branch from 4b77bd6 to 9176ff4 Compare January 7, 2022 18:24
@pacrob pacrob requested review from kclowes and wolovim January 7, 2022 18:25
Copy link
Collaborator

@kclowes kclowes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

@pacrob pacrob merged commit 2e6bcb0 into ethereum:master Jan 7, 2022
@pacrob pacrob deleted the update_docs_contracts_example branch January 7, 2022 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants