Properly initialize external modules #2328
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
We weren't properly initializing external modules that do not inherit from the
web3.module.Module
class. This led to class methods not working as there was noself
to reference.Also, based on our docs, we expected to be able to initialize an external module with passing in a
Web3
instance as the first argument. This was not the case and wasn't tested.How was it fixed?
Module
class by adding()
Web3
instance as the first argument of their__init__()
if it requires use of the web3 instanceTodo:
Cute Animal Picture