Properly initialize external modules #2328
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fselmo
force-pushed
the
bugfix-external-modules
branch
2 times, most recently
from
d944553
to
5e33862
Compare
wolovim
force-pushed
the
bugfix-external-modules
branch
from
9d4fa07
to
df96dd1
Compare
wolovim
approved these changes
Feb 4, 2022
Properly initialize modules that do not inherit from the `web3.module.Module` class. We weren't properly testing self-referential, non-static methods with this functionality and so a test was also added for this.
fselmo
force-pushed
the
bugfix-external-modules
branch
2 times, most recently
from
27713d7
to
c0c5dac
Compare
* Allow for accepting the ``Web3`` instance as the first argument in any module's ``__init()`` method, rather than requiring a module to inherit from ``web3.module.Module`` if it needs to make use of the ``Web3`` instance. * Update tests to test the above change. * Add a more friendly error message if the module has more than one __init__() argument. Add test for this error message / case.
fselmo
force-pushed
the
bugfix-external-modules
branch
from
c0c5dac
to
67f0562
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
We weren't properly initializing external modules that do not inherit from the
web3.module.Moduleclass. This led to class methods not working as there was noselfto reference.Also, based on our docs, we expected to be able to initialize an external module with passing in a
Web3instance as the first argument. This was not the case and wasn't tested.How was it fixed?
Moduleclass by adding()Web3instance as the first argument of their__init__()if it requires use of the web3 instanceTodo:
Cute Animal Picture