Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate ropsten #2672

Merged
merged 2 commits into from
Oct 12, 2022
Merged

Deprecate ropsten #2672

merged 2 commits into from
Oct 12, 2022

Conversation

fselmo
Copy link
Collaborator

@fselmo fselmo commented Oct 8, 2022 •
edited
Loading

What was wrong?

Closes #2627

Note: Review after #2668 since that introduces the towncrier type internal

How was it fixed?

  • Remove references to Ropsten test network

Todo:

Cute Animal Picture

20221008_205752

@fselmo fselmo force-pushed the deprecate-ropsten branch 2 times, most recently from 32a0655 to 8e82ff4 Compare October 8, 2022 00:33
@fselmo fselmo marked this pull request as ready for review October 12, 2022 15:43
@fselmo fselmo requested a review from kclowes October 12, 2022 15:44
kclowes
kclowes approved these changes Oct 12, 2022
View reviewed changes
Copy link
Collaborator

@kclowes kclowes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 nice! It might be nice to add a deprecation warning on v5 since it's not shut down yet AFAICT.

@fselmo fselmo merged commit 630a406 into ethereum:master Oct 12, 2022
@fselmo fselmo deleted the deprecate-ropsten branch April 3, 2024 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kclowes kclowes kclowes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ropsten and Kovan will be deprecated after the Merge
2 participants
@fselmo @kclowes