Clean up old eth abi references #2668
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fselmo
force-pushed
the
clean-up-old-eth-abi-references
branch
2 times, most recently
from
64a2711
to
ae49967
Compare
fselmo
force-pushed
the
clean-up-old-eth-abi-references
branch
3 times, most recently
from
88416d2
to
cee2275
Compare
- With commonly used words like ``encode`` and ``decode``, it is better to import the library so a reader knows what exactly is encoding / decoding. Here, it is better to import ``abi`` and use ``abi.encode()`` / ``abi.decode()`` for better context.
fselmo
force-pushed
the
clean-up-old-eth-abi-references
branch
from
cee2275
to
0b76cde
Compare
- This updates the ``towncrier`` types. Seems like we were missing a few.
fselmo
force-pushed
the
clean-up-old-eth-abi-references
branch
from
ab89b2a
to
c1acffe
Compare
fselmo
commented
Oct 7, 2022
| * `misc` | ||
| * `breaking-change` |
There was a problem hiding this comment.
@kclowes any reason we'd want to keep these different for web3.py? I needed the internal and so I just copy / pasted from the template project. Makes things easier.
There was a problem hiding this comment.
Nope, just hadn't gotten around to changing it. Thanks!
kclowes
approved these changes
Oct 12, 2022
| * `misc` | ||
| * `breaking-change` |
There was a problem hiding this comment.
Nope, just hadn't gotten around to changing it. Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
Related to Issue ethereum/eth-abi#161
How was it fixed?
abi.decode()over the deprecatedabi.decode_single()abiand useabi.encode()andabi.decode()so a reader can have more context when reading the code.Todo:
Cute Animal Picture