Raise external timeout #1070
Merged
Raise external timeout #1070
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carver
force-pushed
the
raise-external-timeout
branch
from
6f3fa16
to
5d0aac4
Compare
|
This shouldn't be backported to v4, because the change in exception is not backwards compatible. Linking to #722 for future documentation needs. |
dylanjw
approved these changes
Sep 24, 2018
|
@carver could we backport to |
|
The only problem I see is that we would have a utils exception import from a non-utils package. |
|
Ignore me, I didn't actually look at the pull request code. Doesn't seem worth the complexity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
We raise
Timeoutexception fromw3.eth.waitForTransactionReceipt(), but the exception is in a private_utilsmodule.How was it fixed?
TimeExhaustedtimeout.waitForTransactionReceiptCute Animal Picture