Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

contract.events.X.getLogs() support without creating filters #1192

Merged
merged 5 commits into from
Jan 17, 2019
Merged

contract.events.X.getLogs() support without creating filters #1192

merged 5 commits into from
Jan 17, 2019

Conversation

miohtama
Copy link
Contributor

@miohtama miohtama commented Jan 8, 2019

What was wrong?

Related to Issue #1177

How was it fixed?

Added a proposed implementation.

Still working on the polish and documentation and test coverage. Opened a PR for early feedback.

Cute Animal Picture

\|/          (__)    
     `\------(oo)
       ||    (__)
       ||w--||     \|/
   \|/

pipermerriam
pipermerriam reviewed Jan 8, 2019
View reviewed changes
web3/contract.py Outdated Show resolved Hide resolved
@miohtama miohtama changed the title [WIP] Initial draft for contract.events.X.getLogs() contract.events.X.getLogs() support without creating filters Jan 14, 2019
@miohtama
Copy link
Contributor Author

Ready to merge if no further comments in a new review.

pipermerriam
pipermerriam approved these changes Jan 16, 2019
View reviewed changes
Copy link
Member

@pipermerriam pipermerriam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@kclowes will leave to you to do final review and merge.

kclowes
kclowes reviewed Jan 16, 2019
View reviewed changes
web3/contract.py Outdated Show resolved Hide resolved
kclowes
kclowes reviewed Jan 16, 2019
View reviewed changes
Copy link
Collaborator

@kclowes kclowes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me! I just left 2 super nitpicky comments. I will update tomorrow and merge or if you get to it before me, feel free to do that. Thanks @miohtama!

@kclowes kclowes merged commit b1c0930 into ethereum:master Jan 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kclowes kclowes kclowes left review comments

@pipermerriam pipermerriam pipermerriam approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@miohtama @pipermerriam @kclowes