Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop deprecated web3.sha3 method #1207

Merged
merged 1 commit into from
Jan 14, 2019

Conversation

njgheorghita
Copy link
Contributor

What was wrong?

From Planned v5 changes issue...

rename Web3.sha3 to Web3.keccak

Related to Issue #722

How was it fixed?

Dropped the already deprecated web3.sha3 method.

Cute Animal Picture

image

Copy link
Collaborator

@kclowes kclowes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @njgheorghita!

@njgheorghita njgheorghita merged commit d215a76 into ethereum:master Jan 14, 2019
@njgheorghita njgheorghita deleted the drop-web3-sha3 branch January 14, 2019 19:39
@njgheorghita njgheorghita mentioned this pull request Jan 17, 2019
22 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants